mirror of
https://github.com/retroSoC/retroSoC.git
synced 2026-11-06 14:55:14 +00:00
refactor: refactor parameter naming conventions and update RTL style
- Changed parameter names in various modules from uppercase to camel case for consistency. - Updated local parameters in testbenches to follow the same naming convention. - Modified the RTL style manifest to include additional prefixes for better organization. - Enhanced the check_format and check_rtl_style scripts to improve file tracking and naming validation. - Added new tests to ensure compliance with the updated naming conventions and allowed local parameters in specific contexts.
This commit is contained in:
48 files changed
+634
-556
No files matched your search
@@ -130,3 +130,32 @@ def test_owned_style_accepts_project_naming_contract(tmp_path: Path) -> None:
|
||||
enforce_naming=True,
|
||||
)
|
||||
assert result.returncode == 0, result.stderr
|
||||
|
||||
|
||||
def test_owned_style_allows_protocol_localparams(tmp_path: Path) -> None:
|
||||
result = run_style(
|
||||
tmp_path,
|
||||
"module test_module #(parameter int DataWidth = 32) ("
|
||||
"input logic clk_i, output logic data_o);\n"
|
||||
" localparam logic [1:0] FSM_IDLE = 2'd0;\n"
|
||||
" localparam logic [1:0] FSM_RESP = 2'd1;\n"
|
||||
" assign data_o = clk_i;\n"
|
||||
"endmodule\n",
|
||||
enforce_naming=True,
|
||||
)
|
||||
assert result.returncode == 0, result.stderr
|
||||
|
||||
|
||||
def test_owned_style_allows_interface_members_and_include_guards(tmp_path: Path) -> None:
|
||||
result = run_style(
|
||||
tmp_path,
|
||||
"`ifndef GPIO_DEFINE_SVH\n"
|
||||
"`define GPIO_DEFINE_SVH\n"
|
||||
"interface test_if ();\n"
|
||||
" logic cmd_valid;\n"
|
||||
" modport dut(input cmd_valid);\n"
|
||||
"endinterface\n"
|
||||
"`endif\n",
|
||||
enforce_naming=True,
|
||||
)
|
||||
assert result.returncode == 0, result.stderr
|
||||
Reference in new issue
Block a user